linux-kernel - Re: [PATCH 10/59] CRED: Wrap task credential accesses in the ISDN drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080827175134.GA15907@pingi.kke.suse.de>
Date:	Wed, 27 Aug 2008 19:51:34 +0200
From:	Karsten Keil <kkeil@...e.de>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	Serge Hallyn <serue@...ibm.com>, Karsten Keil <kkeil@...e.de>,
	isdn4linux@...tserv.isdn4linux.de
Subject: Re: [PATCH 10/59] CRED: Wrap task credential accesses in the ISDN drivers

On Wed, Aug 27, 2008 at 02:46:33PM +0100, David Howells wrote:
> Wrap access to task credentials so that they can be separated more easily from
> the task_struct during the introduction of COW creds.
> 
> Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().
> 
> Change some task->e?[ug]id to task_e?[ug]id().  In some places it makes more
> sense to use RCU directly rather than a convenient wrapper; these will be
> addressed by later patches.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> Reviewed-by: James Morris <jmorris@...ei.org>
> Acked-by: Serge Hallyn <serue@...ibm.com>
> Cc: Karsten Keil <kkeil@...e.de>
> Cc: isdn4linux@...tserv.isdn4linux.de
> ---
> 
>  drivers/isdn/capi/capifs.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/isdn/capi/capifs.c b/drivers/isdn/capi/capifs.c
> index 550e80f..0aa66ec 100644
> --- a/drivers/isdn/capi/capifs.c
> +++ b/drivers/isdn/capi/capifs.c
> @@ -156,8 +156,8 @@ void capifs_new_ncci(unsigned int number, dev_t device)
>  	if (!inode)
>  		return;
>  	inode->i_ino = number+2;
> -	inode->i_uid = config.setuid ? config.uid : current->fsuid;
> -	inode->i_gid = config.setgid ? config.gid : current->fsgid;
> +	inode->i_uid = config.setuid ? config.uid : current_fsuid();
> +	inode->i_gid = config.setgid ? config.gid : current_fsgid();
>  	inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
>  	init_special_inode(inode, S_IFCHR|config.mode, device);
>  	//inode->i_op = &capifs_file_inode_operations;


Acked

-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/