linux-kernel - Re: [PATCH] lockdep: fix invalid list_del_rcu in zap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080827064139.GD6255@elte.hu>
Date:	Wed, 27 Aug 2008 08:41:39 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Zhu Yi <yi.zhu@...el.com>
Cc:	peterz@...radead.org, mingo@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockdep: fix invalid list_del_rcu in zap_class


* Zhu Yi <yi.zhu@...el.com> wrote:

> BUG: unable to handle kernel NULL pointer dereference at
> 0000000000000008
> IP: [<ffffffff810531e1>] zap_class+0x24/0x82

> The root cause for this oops is in add_lock_to_list() when 
> save_trace() fails due to MAX_STACK_TRACE_ENTRIES is reached, 
> entry->class is assigned but entry is never added into any lock list. 
> This makes the list_del_rcu() in zap_class() oops later when the 
> module is unloaded. This patch fixes the problem by assigning 
> entry->class after save_trace() returns success.

good spotting! Applied to tip/core/urgent, thanks.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/