[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.1.00.0808271721140.15543@abydos.NerdBox.Net>
Date: Wed, 27 Aug 2008 17:27:00 -0700 (PDT)
From: Steve VanDeBogart <vandebo-lkml@...dBox.Net>
To: Ingo Molnar <mingo@...e.hu>
cc: linux-kernel@...r.kernel.org, Roland McGrath <roland@...hat.com>,
Oleg Nesterov <oleg@...sign.ru>
Subject: Re: [PATCH] exit signals: use of uninitialized field notify_count
On Wed, 27 Aug 2008, Ingo Molnar wrote:
>
> * Steve VanDeBogart <vandebo-lkml@...dBox.Net> wrote:
>
>> task->signal->notify_count is only initialized if
>> task->signal->group_exit_task is not NULL. Reorder a conditional so
>> that uninitialised memory is not used. Found by Valgrind.
>>
>> Signed-off-by: Steve VanDeBogart <vandebo-lkml@...dbox.net>
>
> Applied the commit below to tip/core/urgent, thanks. Roland/Oleg, do you
> concur with the fix?
>
> nice find btw. - are you running Valgrind on UML?
Thanks. Yes, I am running Valgrind on UML. I revisited the previous
patches that allowed it and tried to remove any unnecessary changes.
The patches and a recipe on how to make it work can be found on the
UML wiki: http://uml.jfdi.org/uml/Wiki.jsp?page=ValgrindingUML
I'll stir up trouble by posting the kernel patches on lkml after a
little more cleanup.
--
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists