[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1219915507.6443.13.camel@twins>
Date: Thu, 28 Aug 2008 11:25:07 +0200
From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
To: bharata@...ux.vnet.ibm.com
Cc: linux-kernel@...r.kernel.org,
Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>,
Ingo Molnar <mingo@...e.hu>
Subject: Re: [patch] sched: call resched_task() conditionally from new task
wake up path.
On Thu, 2008-08-28 at 14:42 +0530, Bharata B Rao wrote:
> Hi,
>
> sched: call resched_task() conditionally from new task wake up path.
>
> - During wake up of a new task, task_new_fair() can do a resched_task()
> on the current task. Later in the code path, check_preempt_curr() also ends
> up doing the same, which can be avoided. Check if TIF_NEED_RESCHED is
> already set for the current task.
>
> - task_new_fair() does a resched_task() on the current task unconditionally.
> This can be done only in case when child runs before the parent.
>
> Signed-off-by: Bharata B Rao <bharata@...ux.vnet.ibm.com>
> CC: Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> CC: Ingo Molnar <mingo@...e.hu>
> ---
> kernel/sched_fair.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> --- a/kernel/sched_fair.c
> +++ b/kernel/sched_fair.c
> @@ -1348,6 +1348,13 @@ static void check_preempt_wakeup(struct
> if (unlikely(se == pse))
> return;
>
> + /*
> + * We can come here with TIF_NEED_RESCHED already set from new task
> + * wake up path.
> + */
> + if (test_tsk_need_resched(curr))
> + return;
> +
> cfs_rq_of(pse)->next = pse;
>
> /*
> @@ -1615,10 +1622,10 @@ static void task_new_fair(struct rq *rq,
> * 'current' within the tree based on its new key value.
> */
> swap(curr->vruntime, se->vruntime);
> + resched_task(rq->curr);
> }
>
> enqueue_task_fair(rq, p, 0);
> - resched_task(rq->curr);
> }
>
> /*
>
> Regards,
> Bharata.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists