linux-kernel - Re: [PATCH] e1000: fix stack size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef1cd66f0808280317r72f98402x5f4c23bf4aaf100d@mail.gmail.com>
Date:	Thu, 28 Aug 2008 11:17:19 +0100
From:	"Jochen Voß" <jochen.voss@...glemail.com>
To:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
Cc:	jeff@...zik.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, davem@...emloft.net,
	akpm@...ux-foundation.org,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] e1000: fix stack size

Hi,

2008/8/27 Jeff Kirsher <jeffrey.t.kirsher@...el.com>:
> From: Linus Torvalds <torvalds@...ux-foundation.org>
>
> Here's the patch. It shrinks the stack from 1152 bytes to 192 bytes (the
> first version, that only did the e1000_option part, got it down to 600
> bytes). About half comes from not using multiple "e1000_option"
> structures, the other half comes from turning the "e1000_opt_list[]"
> arrays into "static const" instead, so that gcc doesn't copy them onto the
> stack.
>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Reveiewed-by: Auke Kok <auke-jan.h.kok@...el.com>
  ^^^^^^^^^^^^^^
  typo here

> Tested-by: Emil Tantilov <emil.s.tantilov@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

I hope this helps,
Jochen
-- 
http://seehuhn.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/