[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20080828005218.GD16607@us.ibm.com>
Date: Wed, 27 Aug 2008 19:52:18 -0500
From: "Serge E. Hallyn" <serue@...ibm.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, ebiederm@...ssion.com,
David Howells <dhowells@...hat.com>
Subject: Re: [PATCH 1/3] user namespaces: introduce
user_struct->user_namespace relationship
Quoting Andrew Morton (akpm@...ux-foundation.org):
> On Tue, 26 Aug 2008 13:53:41 -0500
> "Serge E. Hallyn" <serue@...ibm.com> wrote:
>
> > When a task does clone(CLONE_NEWNS), the task's user is the 'creator' of the
> > new user_namespace, and the user_namespace is tacked onto a list of those
> > created by this user.
> >
> > Changelog:
> > Aug 25: make free_user not inlined as it's not trivial. (Eric
> > Biederman suggestion)
> > Aug 1: renamed user->user_namespace to user_ns, as the next
> > patch did anyway.
> > Aug 1: move put_user_ns call in one free_user() definition
> > to move it outside the lock in free_user. put_user_ns
> > calls free_user on the user_ns->creator, which in
> > turn would grab the lock again.
> >
> > Signed-off-by: Serge Hallyn <serue@...ibm.com>
> > ---
> > include/linux/sched.h | 1 +
> > include/linux/user_namespace.h | 1 +
> > kernel/user.c | 11 +++++++++--
> > kernel/user_namespace.c | 20 +++++++++++---------
>
> The credentials code in linux-next is changing the same code which
> you're changing, in more-than-trivially-textual ways.
Ok, I knew that was coming eventually. I'll rebase.
> I'd suggest a dhowells cc on these changes, as he's also working
> in this area, and as you touch the keyring code a bit.
Ok.
> And, of course, please remove that almost-always-wrong
> extern-declaration-in-C which checkpatch told you about. init_groups
> is already declared in include/linux/init_task.h anyway...
Sorry, will do with the rebase.
Thanks, Andrew.
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists