linux-kernel - Re: [PATCH 3/5] checkpatch: complex macros need to ignore comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080828151744.GD27763@brain>
Date:	Thu, 28 Aug 2008 16:17:44 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Jan Engelhardt <jengelh@...ozas.de>
Cc:	Andrew Morton <akpm@...l.org>, Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] checkpatch: complex macros need to ignore comments

On Sat, Jul 05, 2008 at 08:44:35PM +0200, Jan Engelhardt wrote:
> 
> On Wednesday 2008-07-02 13:31, Andy Whitcroft wrote:
> 
> >Ensure we ignore comments in complex macro detection else we incorrectly
> >report this:
> >
> >	#define PFM_GROUP_PERM_ANY     -1      /* any user/group */
> 
> Does it also catch this ugly piece from dcache.c?
> 
> 
> #define DCACHE_NFSFS_RENAMED  0x0002    /* this dentry has been "silly
>                                          * renamed" and has to be
>                                          * deleted on the last dput()
>                                          */

Yeah it should indeed.  A quick check with the current version seems to
confirm that.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/