linux-kernel - Re: [PATCH RESEND] char_dev: add cdev->release() and convert cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Aug 2008 10:38:13 -0700
From:	Greg KH <greg@...ah.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] char_dev: add cdev->release() and convert
	cdev_alloc() to use it

On Thu, Aug 28, 2008 at 06:56:48PM +0200, Tejun Heo wrote:
> Greg KH wrote:
> > Ick, I really don't want struct cdev to be used for lifecycle
> > management, as it is only for major:minor stuff.  Why do you want to
> > make this change?
> 
> Well, as cdev can be referenced from userspace, ->release is required
> for most purposes.  The reason why devices have been getting by without
> it is because most chardevs are created on module load and destroyed on
> module unload and in the meantime cdev refcount virtually equals module
> refcnt, but I'm fairly sure we have cases where cdev can be destroyed
> for other reasons then module unloading and it's very likely those cases
> are buggy in the current code (backing structure gone bug cdev still
> hanging around).

Hm, I thought Al covered that when he created the cdev interface, I
would be a bit supprised if this was the case.

> As CUSE can create and destroy devices regardless of module reference
> count, it falls in the second category and needs cdev->release() to make
> sure the backing structure doesn't go away till cdev is released.

But CUSE should be it's own module, right?  And it would "own" the cdev,
so the module and cdev count should be fine and matching.  The userspace
code could go away but the CUSE code should handle that with a different
reference count.  This is the way that hardware drivers handle the
issue.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/