linux-kernel - Re: [RFC][PATCH] bitfields API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080828184025.GA22165@x200.localdomain>
Date:	Thu, 28 Aug 2008 22:40:25 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Vegard Nossum <vegard.nossum@...il.com>
Cc:	David Miller <davem@...emloft.net>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] bitfields API

On Thu, Aug 28, 2008 at 08:32:23PM +0200, Vegard Nossum wrote:
> How do you feel about this patch? It's all about making kmemcheck more
> useful... and not much else. Does it have any chance of entering the
> kernel along with kmemcheck (when/if that happens)?

DEFINE_BITFIELD is horrible.

> @@ -285,11 +286,12 @@ struct sk_buff {
>  		};
>  	};
>  	__u32			priority;
> -	__u8			local_df:1,
> +	DEFINE_BITFIELD(__u8,	flags1,
> +				local_df:1,
>  				cloned:1,
>  				ip_summed:2,
>  				nohdr:1,
> -				nfctinfo:3;
> +				nfctinfo:3);
>  	__u8			pkt_type:3,
>  				fclone:2,
>  				ipvs_property:1,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/