linux-kernel - Re: [PATCH] afs: fsclient.c sparse endian annotations of operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080828022230.GF28946@ZenIV.linux.org.uk>
Date:	Thu, 28 Aug 2008 03:22:30 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	dhowells@...hat.com, harvey.harrison@...il.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] afs: fsclient.c sparse endian annotations of
	operation_ID

On Wed, Aug 27, 2008 at 04:17:05AM -0700, David Miller wrote:
> From: David Howells <dhowells@...hat.com>
> Date: Wed, 27 Aug 2008 12:12:24 +0100
> 
> > Harvey Harrison <harvey.harrison@...il.com> wrote:
> > 
> > > +		if (call->operation_ID != __constant_htonl(FSFETCHDATA64)) {
> > 
> > Doesn't htonl() resolve to this for a constant argument?  Following through
> > the definitions, it certainly looks like it ought to:
> 
> Yes it does.
> 
> The __constant_*() interfaces should only be uses for things that
> must be evaluated at compile time (static data initializations,
> switch statement case values etc.).

It's not just "must be evaluated at compile time"; it's "must be C constant
expressions", which is much stricter.  And no, in the case quoted above
__constant_ form is not needed.  Just use htonl()...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/