linux-kernel - Re: [PATCH] USB: add USB test and measurement class driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080828203844.GC20537@kroah.com>
Date:	Thu, 28 Aug 2008 13:38:44 -0700
From:	Greg KH <greg@...ah.com>
To:	Marcel Janssen <korgull@...e.nl>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Oliver Neukum <oliver@...kum.org>,
	USB list <linux-usb@...r.kernel.org>,
	Stefan Kopp <stefan_kopp@...lent.com>,
	Felipe Balbi <me@...ipebalbi.com>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: add USB test and measurement class driver - round
	2

On Thu, Aug 28, 2008 at 06:58:41PM +0200, Marcel Janssen wrote:
> On Thursday 28 August 2008 01:47:20 Greg KH wrote:
> > Great, all done now.
> >
> > Here's the updated version.
> 
> I've just installed this version.
> 
> Here's what I see so far :
> 
> The driver inserts well and when I connect my device it shows /dev/usbtmc0 
> with major 180 and minor 176.
> It only creates one device (Stefan's driver created two) but I'm not sure if 
> that has changed for a reason so just let you know.

Yes, the old driver had a "control and debug " channel at minor 0, which
isn't needed anymore.

> When I disconnect my device, usbtmc0 will not be destroyed. After connecting 
> the device a couple of times I have a lot of /dev/usbtmc.. files.

Hm, that's not good, something's wrong here.

Can you enable CONFIG_USB_DEBUG and rebuild the driver and send me the
kernel log messages when you plug the device in and then remove it?

> I would expect the following to work :
> echo :*IDN?>/dev/usbtmc0
> But it returns : No such device

Yeah, I would expect that to work as well.  The debug information might
be helpful here also.

> Using echo and cat to test the device is quite convenient, but is this 
> supposed to work yet ?

Yes it should.

> I checked /sys a bit and found that the endpoints are correctly found.    

Good, how about the capability information?  That should be in sysfs as
well, does that show the proper values?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/