linux-kernel - Re: [Patch] Fix another bug in hfsplus when reading a corrupted image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0808290409220.2507@localhost.localdomain>
Date:	Fri, 29 Aug 2008 04:21:18 +0200 (CEST)
From:	Roman Zippel <zippel@...ux-m68k.org>
To:	Eric Sesterhenn <snakebyte@....de>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [Patch] Fix another bug in hfsplus when reading a corrupted
 image

Hi,

On Tue, 26 Aug 2008, Eric Sesterhenn wrote:

> Problem is that there is no ext_tree, causing the NULL-pointer
> dereference in hfsplus_init(). This fixes the issue by checking the ext_tree in
> hfsplus_get_block() and aborting early enoug.

The problem is worse, a corrupted extent for the extent file itself may 
try to get an impossible extent, causing a deadlock if I see it correctly.
A better fix would be to check the inode number after the first_blocks 
checks and fail if it's the extent file, as according to the spec the 
extent file should have no extent for itself.

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/