[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080829155319.dc76b1c0.akpm@linux-foundation.org>
Date: Fri, 29 Aug 2008 15:53:19 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Yinghai Lu" <yhlu.kernel@...il.com>
Cc: mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dyn_array: using %pF instead of
print_fn_descriptor_symbol
> ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);
> if (!ptr)
> panic("Can not alloc dyn_alloc\n");
Why duplicate the panic()? Just call __alloc_bootmem().
> #ifdef CONFIF_GENERIC_HARDIRQS
That doesn't appear to have been very well tested?
The code has a few coding-style glitches which checkpatch can detect.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists