linux-kernel - Re: [PATCH] ne.c fix for hibernate and rmmod oops fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080830.235226.108118828.anemo@mba.ocn.ne.jp>
Date:	Sat, 30 Aug 2008 23:52:26 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	david@...es.net
Cc:	linux-kernel@...r.kernel.org, p_gortmaker@...oo.com,
	netdev@...r.kerne.org
Subject: Re: [PATCH] ne.c fix for hibernate and rmmod oops fix

On Fri, 29 Aug 2008 21:27:49 -0500, David Fries <david@...es.net> wrote:
> > With your patch, cleanup_module() and ne_exit() is exactly same.  How
> > about unifying them?
> 
> They didn't use to be the same, with all the cleanup I didn't notice
> that they became the same.  ne_exit is no more, cleanup_module for
> both module and built in.

The name "cleanup_module" is special.  I think this should not be used
outside #ifdef MODULE.  Please rename it something like
ne_cleanup_module() and make it static.  Or just use ne_exit().

> > This .name initialization seems a bit redundant for me.  They can be
> > left NULL.
> 
> Changed.

Thanks.  You killed two .name and there are still two .name in ne_probe.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/