lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20080830090411.03791b5a@infradead.org>
Date:	Sat, 30 Aug 2008 09:04:11 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Joe Korty <joe.korty@...r.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] make might_sleep() display the oopsing process

On Sat, 30 Aug 2008 10:45:20 -0400
Joe Korty <joe.korty@...r.com> wrote:

> On Fri, Aug 29, 2008 at 07:20:03PM -0400, Andrew Morton wrote:
> > On Thu, 28 Aug 2008 11:36:28 +0200
> > Ingo Molnar <mingo@...e.hu> wrote:
> > 
> > > > Expand might_sleep's printk to indicate the oopsing process.
> > >
> > > good idea
> > 
> > Why?  I don't recall ever having been interested in this
> > information.
> > 
> > (I shouldn't have to ask questions like this.  Please spend a little
> > more time in preparing the patch descriptions).
> 
> I wrote and used the patch once, as I wanted to know
> which program in a lengthy multiple-program test suite
> was triggering the problem.  That made it easier coming
> up with a shortened test that would replicate the problem.
> 
> However I only needed it that one time so this patch can
> be considered to be exceptionally optional :)

WARN() and WARN_ON() already print the oopsing process.
so if might_sleep() just calls one of those it already prints it.
If it doesn't call one of these.. maybe it should?


-- 
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ