[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <18617.35916.80075.481108@harpo.it.uu.se>
Date: Sat, 30 Aug 2008 20:07:08 +0200
From: Mikael Pettersson <mikpe@...uu.se>
To: Greg KH <gregkh@...e.de>
Cc: Mikael Pettersson <mikpe@...uu.se>, fujita.tomonori@....ntt.co.jp,
dwmw2@...radead.org, jens.axboe@...cle.com,
linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION 2.6.27-rc4-git7] mtd broken by cmdfilter move
Greg KH writes:
> > --- linux-2.6.27-rc4-git6/block/cmd-filter.c.~1~ 2008-08-30 17:08:58.000000000 +0200
> > +++ linux-2.6.27-rc4-git6/block/cmd-filter.c 2008-08-30 17:36:36.000000000 +0200
> > @@ -215,6 +215,13 @@ int blk_register_filter(struct gendisk *
> > if (!parent)
> > return -ENODEV;
> >
> > + printk("%s: disk %p queue %p filter %p &filter->kobj %p\n",
> > + __func__, disk, disk->queue, filter, &filter->kobj);
> > + if (filter->kobj.state_initialized) {
> > + printk("%s: kobj %p already inited, bailing out\n",
> > + __func__, &filter->kobj);
> > + return 0;
> > + }
>
> Ick, no, don't go poking into the internals of a kobject like this to
> fix this kind of problem. If you really don't know if you have
> initialized this kobject or not, then you will have reference counting
> problems, which need to be fixed for real.
This was a debug patch, I wasn't suggesting it as "the" fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists