lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 Aug 2008 09:51:34 -0600 From: Matthew Wilcox <matthew@....cx> To: James Bottomley <James.Bottomley@...senPartnership.com> Cc: Simon Arlott <simon@...e.lp0.eu>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-scsi <linux-scsi@...r.kernel.org> Subject: Re: [PATCH 1/2] lib: add generic helper to print sizes rounded to the correct SI range On Sun, Aug 31, 2008 at 10:13:54AM -0500, James Bottomley wrote: > +int string_get_size(u64 size, const enum string_size_units units, > + char *buf, int len) > +{ > + const char *units_10[] = { "B", "KB", "MB", "GB", "TB", "PB", > + "EB", "ZB", "YB", NULL}; > + const char *units_2[] = {"B", "Kib", "MiB", "GiB", "TiB", "PiB", Typo for KiB? Should this be another %p extension instead? %pB and %piB perhaps? That would seem easier for the callers than futzing around with managing their own string buffers. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists