[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <72981EBCFD196144B7C6999B9FC34A9A3EE62D7C3C@SHEXMB-01.global.atheros.com>
Date: Sun, 31 Aug 2008 13:31:02 +0800
From: Jie Yang <Jie.Yang@...eros.com>
To: Matthew Wilcox <matthew@....cx>
CC: "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"bugme-daemon@...zilla.kernel.org" <bugme-daemon@...zilla.kernel.org>,
"harn-solo@....de" <harn-solo@....de>,
"jeff@...zik.org" <jeff@...zik.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH]atl1e:fix bug [Bug 11454] New: atl1e - BUG: scheduling
while atomic: modprobe/678/0x00000002
On Sunday, August 31, 2008 1:09 PM
Matthew Wilcox <matthew@....cx> wrote:
> How about taking my original patch, sent August 12th instead?
> That has a good changelog and proper attribution. The
> removal of the unnecessary casts can be a separate message.
>
> If you weren't cc'd on the patch (Jeff was), you can pick it
> up from netdev.
>
Yes, I do have the patch, should I resend with Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>.
for that patch may have conflicts now.
the origin patch:
diff --git a/drivers/net/atl1e/atl1e_main.c b/drivers/net/atl1e/atl1e_main.c index 82d7be1..ba22a51 100644
--- a/drivers/net/atl1e/atl1e_main.c
+++ b/drivers/net/atl1e/atl1e_main.c
@@ -2389,9 +2389,7 @@ static int __devinit atl1e_probe(struct pci_dev *pdev,
}
/* Init GPHY as early as possible due to power saving issue */
- spin_lock(&adapter->mdio_lock);
atl1e_phy_init(&adapter->hw);
- spin_unlock(&adapter->mdio_lock);
/* reset the controller to
* put the device in a known good starting state */
err = atl1e_reset_hw(&adapter->hw);
the new one:
diff --git a/drivers/net/atl1e/atl1e_main.c b/drivers/net/atl1e/atl1e_main.c
index 7685b99..9b60352 100644
--- a/drivers/net/atl1e/atl1e_main.c
+++ b/drivers/net/atl1e/atl1e_main.c
@@ -2390,9 +2390,7 @@ static int __devinit atl1e_probe(struct pci_dev *pdev,
}
/* Init GPHY as early as possible due to power saving issue */
- spin_lock(&adapter->mdio_lock);
atl1e_phy_init(&adapter->hw);
- spin_unlock(&adapter->mdio_lock);
/* reset the controller to
* put the device in a known good starting state */
err = atl1e_reset_hw(&adapter->hw);
the line num changed from 2389 to 2390. :(
Best wishes
jie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists