linux-kernel - Re: [alsa-devel] [PATCH 3/4] ASOC: WM8731 codec: add SPI support as well as I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1220277616.6499.119.camel@odin>
Date:	Mon, 01 Sep 2008 15:00:16 +0100
From:	Liam Girdwood <lrg@...nel.org>
To:	Alan Horstmann <gineera@...ect135.co.uk>
Cc:	Bryan Wu <cooloney@...nel.org>, Cliff Cai <cliff.cai@...log.com>,
	alsa-devel@...a-project.org, liam.girdwood@...fsonmicro.com,
	broonie@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH 3/4] ASOC: WM8731 codec: add SPI support
	as well as I2C

On Mon, 2008-09-01 at 14:52 +0100, Alan Horstmann wrote:
> We have just started trying this out as an alternative to i2c, and picked out 
> the following:
> 
> On Wednesday 27 August 2008 10:39, Bryan Wu wrote:
> > -#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
> > +#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE) && !defined
> > (CONFIG_SND_SOC_WM8731_SPI)
> 
> I think this needs extra brackets round the ||'s before the && thus:
> 
> > +#if (defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)) && !defined
> > (CONFIG_SND_SOC_WM8731_SPI)
> 
> in order to force use of SPI when (CONFIG_SND_SOC_WM8731_SPI) and (CONFIG_I2C) 
> are both defined.  Or have we misunderstood the intention?  This is in 2 
> other places also in the patch.
> 

It may be simpler to only have CONFIG_SND_SOC_WM8731_SPI and
CONFIG_SND_SOC_WM8731_I2C definitions for all the codec drivers. These
would be set by machine Kconfig. 

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/