linux-kernel - Re: [PATCH 3/4 v2] PCI: support SR-IOV capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080901153020.GD16796@ldl.fc.hp.com>
Date:	Mon, 1 Sep 2008 09:30:20 -0600
From:	Alex Chiang <achiang@...com>
To:	"Zhao, Yu" <yu.zhao@...el.com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>, linux-pci@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Greg KH <greg@...ah.com>,
	Grant Grundler <grundler@...isc-linux.org>,
	Matthew Wilcox <matthew@....cx>, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org,
	xen-devel@...ts.xensource.com
Subject: Re: [PATCH 3/4 v2] PCI: support SR-IOV capability

* Zhao, Yu <yu.zhao@...el.com>:
> Support SR-IOV capability. By default, this feature is not enabled and the SR-IOV device behaves as traditional PCI device. After it's enabled, each Virtual Function's PCI configuration space can be accessed using its own Bus, Device and Function Number (Routing ID). Each Virtual Function also has PCI Memory Space, which is used to map its own register set.
> 
> Signed-off-by: Yu Zhao <yu.zhao@...el.com>
> Signed-off-by: Eddie Dong <eddie.dong@...el.com>
> 
> ---
>  drivers/pci/Kconfig      |   10 +
>  drivers/pci/Makefile     |    2 +
>  drivers/pci/iov.c        |  555 ++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/pci/pci.c        |   14 +-
>  drivers/pci/pci.h        |   44 ++++
>  drivers/pci/probe.c      |    5 +
>  include/linux/pci.h      |   28 +++
>  include/linux/pci_regs.h |   20 ++
>  8 files changed, 677 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/pci/iov.c
> 
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index f43cc46..0a1fe01 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -57,3 +57,13 @@ config PCI_ARI
>  	default n
>  	help
>  	  This enables PCI Alternative Routing-ID Interpretation.
> +
> +config PCI_IOV
> +	bool "PCI SR-IOV support"
> +	depends on PCI && HOTPLUG
> +	select PCI_MSI
> +	select PCI_ARI
> +	select HOTPLUG_PCI
> +	default n
> +	help
> +	  This allows device drivers to enable Single Root I/O Virtualization.

I'd like to see this Kconfig help text enhanced too. Telling a
user that PCI_IOV enables Single Root I/O Virtualization isn't
that helpful, but explaining what SR-IOV actually gets you _is_
helpful.

	This option allows device drivers to enable Single Root I/O
	Virtualization.  Each Virtual Function's PCI configuration
	space can be accessed using its own Bus, Device and Function
	Number (Routing ID). Each Virtual Function also has PCI Memory
	Space, which is used to map its own register set.

Thanks.

/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/