linux-kernel - Re: [RFC][PATCH] Remove cgroup member from struct page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080901155930.e45a36c8.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Mon, 1 Sep 2008 15:59:30 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	balbir@...ux.vnet.ibm.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>, hugh@...itas.com,
	menage@...gle.com, xemul@...nvz.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	"nickpiggin@...oo.com.au" <nickpiggin@...oo.com.au>
Subject: Re: [RFC][PATCH] Remove cgroup member from struct page

On Mon, 01 Sep 2008 11:55:39 +0530
Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:

> KAMEZAWA Hiroyuki wrote:
> > On Mon, 01 Sep 2008 11:39:26 +0530
> > Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
> > 
> > 
> >>> The development of lockless-page_cgroup is not stalled. I'm just waiting for
> >>> my 8cpu box comes back from maintainance...
> >>> If you want to see, I'll post v3 with brief result on small (2cpu) box.
> >>>
> >> I understand and I am not pushing you to completing it, but at the same time I
> >> don't want to queue up behind it for long. I suspect the cost of porting
> >> lockless page cache on top of my patches should not be high, but I'll never know
> >> till I try :)
> >>
> > My point is, your patch adds big lock. Then, I don't have to do meaningless effort
> > to reduce lock.
> 
> My patch does not add a big lock, it moves the lock from struct
> page->page_cgroup to struct page_cgroup. The other locking added is the locking
> overhead associated with inserting entries into the radix tree, true. I ran
> oprofile along with lockdep and lockstats enabled on my patches. I don't see the
> radix_tree or page_cgroup->lock showing up, I see __slab_free and __slab_alloc
> showing up. I'll poke a little further.
> 
Hmm, one concern I have now is I don't see any contention on  res_counter->lock in
recent lock_stat test....which was usually on the top of list in past.
Did you see it ?

> Please don't let my patch stop you, we'll integrate the best of both worlds and
> what is good for memcg.
> 
Thank you.

To be honest, I wonder control via page_cgroup may be too rich for 32bit archs ;(.

Regards,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/