| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200809011728.57276.nickpiggin@yahoo.com.au>
Date: Mon, 1 Sep 2008 17:28:56 +1000
From: Nick Piggin <nickpiggin@...oo.com.au>
To: Christoph Lameter <cl@...ux-foundation.org>
Cc: Pekka Enberg <penberg@...helsinki.fi>, akpm@...ux-foundation.org,
Alexander Viro <viro@....linux.org.uk>,
Christoph Hellwig <hch@...radead.org>,
Christoph Lameter <clameter@....com>,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
Mel Gorman <mel@...net.ie>, andi@...stfloor.org,
Rik van Riel <riel@...hat.com>, mpm@...enic.com,
Dave Chinner <david@...morbit.com>
Subject: Re: [patch 3/3] dentries: dentry defragmentation
This doesn't come with any numbers or test cases or results?
On Tuesday 26 August 2008 07:20, Christoph Lameter wrote:
> The dentry pruning for unused entries works in a straightforward way. It
> could be made more aggressive if one would actually move dentries instead
> of just reclaiming them.
>
> Cc: Alexander Viro <viro@....linux.org.uk>
> Cc: Christoph Hellwig <hch@...radead.org>
> Reviewed-by: Rik van Riel <riel@...hat.com>
> Signed-off-by: Christoph Lameter <clameter@....com>
> Signed-off-by: Christoph Lameter <cl@...ux-foundation.org>
>
> ---
> fs/dcache.c | 101
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file
> changed, 100 insertions(+), 1 deletion(-)
>
> Index: linux-next/fs/dcache.c
> ===================================================================
> --- linux-next.orig/fs/dcache.c 2008-08-25 15:55:24.000000000 -0500
> +++ linux-next/fs/dcache.c 2008-08-25 15:59:46.000000000 -0500
> @@ -32,6 +32,7 @@
> #include <linux/seqlock.h>
> #include <linux/swap.h>
> #include <linux/bootmem.h>
> +#include <linux/backing-dev.h>
> #include "internal.h"
>
>
> @@ -163,7 +164,10 @@
>
> list_del(&dentry->d_u.d_child);
> dentry_stat.nr_dentry--; /* For d_free, below */
> - /*drops the locks, at that point nobody can reach this dentry */
> + /*
> + * drops the locks, at that point nobody (aside from defrag)
> + * can reach this dentry
> + */
> dentry_iput(dentry);
> parent = dentry->d_parent;
> d_free(dentry);
> @@ -2270,6 +2274,100 @@
> INIT_HLIST_HEAD(&dentry_hashtable[loop]);
> }
>
> +/*
> + * The slab allocator is holding off frees. We can safely examine
> + * the object without the danger of it vanishing from under us.
> + */
> +static void *get_dentries(struct kmem_cache *s, int nr, void **v)
> +{
> + struct dentry *dentry;
> + int i;
> +
> + spin_lock(&dcache_lock);
> + for (i = 0; i < nr; i++) {
> + dentry = v[i];
> +
> + /*
> + * Three sorts of dentries cannot be reclaimed:
> + *
> + * 1. dentries that are in the process of being allocated
> + * or being freed. In that case the dentry is neither
> + * on the LRU nor hashed.
> + *
> + * 2. Fake hashed entries as used for anonymous dentries
> + * and pipe I/O. The fake hashed entries have d_flags
> + * set to indicate a hashed entry. However, the
> + * d_hash field indicates that the entry is not hashed.
> + *
> + * 3. dentries that have a backing store that is not
> + * writable. This is true for tmpsfs and other in
> + * memory filesystems. Removing dentries from them
> + * would loose dentries for good.
> + */
> + if ((d_unhashed(dentry) && list_empty(&dentry->d_lru)) ||
> + (!d_unhashed(dentry) && hlist_unhashed(&dentry->d_hash)) ||
> + (dentry->d_inode &&
> + !mapping_cap_writeback_dirty(dentry->d_inode->i_mapping)))
> + /* Ignore this dentry */
> + v[i] = NULL;
> + else
> + /* dget_locked will remove the dentry from the LRU */
> + dget_locked(dentry);
> + }
> + spin_unlock(&dcache_lock);
> + return NULL;
> +}
> +
> +/*
> + * Slab has dropped all the locks. Get rid of the refcount obtained
> + * earlier and also free the object.
> + */
> +static void kick_dentries(struct kmem_cache *s,
> + int nr, void **v, void *private)
> +{
> + struct dentry *dentry;
> + int i;
> +
> + /*
> + * First invalidate the dentries without holding the dcache lock
> + */
> + for (i = 0; i < nr; i++) {
> + dentry = v[i];
> +
> + if (dentry)
> + d_invalidate(dentry);
> + }
> +
> + /*
> + * If we are the last one holding a reference then the dentries can
> + * be freed. We need the dcache_lock.
> + */
> + spin_lock(&dcache_lock);
> + for (i = 0; i < nr; i++) {
> + dentry = v[i];
> + if (!dentry)
> + continue;
> +
> + spin_lock(&dentry->d_lock);
> + if (atomic_read(&dentry->d_count) > 1) {
> + spin_unlock(&dentry->d_lock);
> + spin_unlock(&dcache_lock);
> + dput(dentry);
> + spin_lock(&dcache_lock);
> + continue;
> + }
> +
> + prune_one_dentry(dentry);
> + }
> + spin_unlock(&dcache_lock);
> +
> + /*
> + * dentries are freed using RCU so we need to wait until RCU
> + * operations are complete.
> + */
> + synchronize_rcu();
> +}
> +
> static void __init dcache_init(void)
> {
> int loop;
> @@ -2279,6 +2377,7 @@
> dcache_ctor);
>
> register_shrinker(&dcache_shrinker);
> + kmem_cache_setup_defrag(dentry_cache, get_dentries, kick_dentries);
>
> /* Hash may have been set up in dcache_init_early */
> if (!hashdist)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists