linux-kernel - Re: [PATCH v3] usb: add Freescale QE/CPM USB peripheral controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200809021401.25506.arnd@arndb.de>
Date:	Tue, 2 Sep 2008 14:01:24 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Li Yang <leoli@...escale.com>
Cc:	greg@...ah.com, linux-usb@...r.kernel.org,
	dbrownell@...rs.sourceforge.net, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org, avorontsov@...mvista.com
Subject: Re: [PATCH v3] usb: add Freescale QE/CPM USB peripheral controller driver

On Tuesday 02 September 2008, Li Yang wrote:
> Some of Freescale SoC chips have a QE or CPM co-processor which
> supports full speed USB.  The driver adds device mode support
> of both QE and CPM USB controller to Linux USB gadget.  The
> driver is tested with MPC8360 and MPC8272, and should work with
> other models having QE/CPM given minor tweaks.
> 
> Signed-off-by: Xie Xiaobo <X.Xie@...escale.com>
> Signed-off-by: Li Yang <leoli@...escale.com>

Acked-by: Arnd Bergmann <arnd@...db.de>

All my previous review comments have been addressed.

> +	udc_controller->soc_type = (unsigned long)np->data;

I'm not sure about this line, shouldn't that be
	udc_controller->soc_type = (unsigned long)match->data; ?

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/