linux-kernel - Re: [PATCH, resend] x86: x86_{phys,virt}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48BDBA56.8050208@zytor.com>
Date:	Tue, 02 Sep 2008 15:12:38 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jan Beulich <jbeulich@...ell.com>
CC:	mingo@...e.hu, tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH, resend] x86: x86_{phys,virt}_bits field also for i386

Jan Beulich wrote:
> Make the x86_{phys,virt}_bits common for 32- and 64-bits, and use the
> former in ioremap's phys_addr_valid() check also on 32bit/PAE.
> 
> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
>  
>  	c->x86_cache_alignment = 32;
>  	c->x86_clflush_size = 32;
> +#ifdef CONFIG_X86_PAE
> +	c->x86_phys_bits = 36;
> +#else
> +	c->x86_phys_bits = 32;
> +#endif
> +	c->x86_virt_bits = 32;
>  

This is logical but wrong.  This is supposed to be about the CPU, not 
about the kernel.

That would mean using the physbit information if it is present, 
otherwise (pae_feature_bit ? 36 : 32).

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/