linux-kernel - Re: [PATCH 3/3] Define and use PCI_DEVICE_ID_MARVELL_88ALP01

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080903095446.330c70d1@bike.lwn.net>
Date:	Wed, 3 Sep 2008 09:54:46 -0600
From:	Jonathan Corbet <corbet@....net>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	linux-kernel@...r.kernel.org, devel@...top.org
Subject: Re: [PATCH 3/3] Define and use PCI_DEVICE_ID_MARVELL_88ALP01_CCIC
 for CAFÉ camera driver

On Wed, 03 Sep 2008 11:48:22 +0100
David Woodhouse <dwmw2@...radead.org> wrote:

> Also, stop looking at the NAND controller (0x4100) and checking the
> device class. For a while during development, all three functions on
> the chip had the same ID. We made them fix that fairly promptly, and
> we can forget about it now.

I see no harm in having the driver check the device to ensure it's what
it thinks it is - we can probably afford the runtime overhead.  But
whatever, I'm not that concerned; toss in an

	Acked-by: Jonathan Corbet <corbet@....net>

if you wish.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/