linux-kernel - Re: [PATCH] Fix TSC calibration issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48BE13C5.8020604@lwfinger.net>
Date:	Tue, 02 Sep 2008 23:34:13 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Alok Kataria <akataria@...are.com>,
	Michael Buesch <mb@...sch.de>
Subject: Re: [PATCH] Fix TSC calibration issues

Linus Torvalds wrote:
> 
> On Tue, 2 Sep 2008, Larry Finger wrote:
>> I know that Linus has some problems with this patch, but FWIW it worked on my
>> K6. The dmesg output is
>>
>> TSC: PIT calibration deviates from PMTIMER: 428809 214401.
>> TSC: Using PIT calibration value
>> Detected 428.809 MHz processor.
> 
> I don't have a problem with what the patch _does_ (I think all the added 
> sanity checking is good).
> 
> I just don't like how it makes the already rather complex and confusing 
> function about ten times _more_ complex and confusing. It needs splitting 
> up.
> 
> But we can split it up after-the-fact as well as before-the-fact.
> 
> Does this cleanup-patch (on _top_ of Thomas' patch) also work for you? It 
> should do exactly the same thing, except it splits up the TSC PIT 
> calibration into a function of its own.
> 
> But I may obviously have introduced some silly bug when cleaning it up, 
> so testing necessary..

Same result as Thomas' version.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/