linux-kernel - Re: drivers/char/random.c line 728 BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Sep 2008 11:28:45 -0700
From:	Aaron Straus <aaron@...finllc.com>
To:	Matt Mackall <mpm@...enic.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Theodore Ts'o <tytso@....edu>,
	stable@...nel.org
Subject: Re: drivers/char/random.c line 728 BUG

Hi Matt,

On Sep 03 01:18 PM, Matt Mackall wrote:
> This fix is bogus - it assumes that r->entropy_count has atomic
> assignment which is not universally true (witness the existence of
> atomic_t). So we can still observe partial updates to entropy_count on
> some architectures. Now it's probably the case that we'll never see a
> partial update that actually triggers the BUG_ON, but it's still
> conceptually wrong to do things this way.

I think Andrew was just being safe by reverting to the old behavior.

Could we still apply his patch for the upcoming stable tree and fix it
the "right" way at some point in the future?

				Thanks,
				=a=

-- 
===================
Aaron Straus
aaron@...finllc.com

Download attachment "signature.asc" of type "application/pgp-signature" (192 bytes)