linux-kernel - Re: drivers/char/random.c line 728 BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080903161248.6f7ee1ff.akpm@linux-foundation.org>
Date:	Wed, 3 Sep 2008 16:12:48 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Matt Mackall <mpm@...enic.com>
Cc:	aaron@...finllc.com, linux-kernel@...r.kernel.org, tytso@....edu,
	stable@...nel.org
Subject: Re: drivers/char/random.c line 728 BUG

On Wed, 03 Sep 2008 17:51:37 -0500
Matt Mackall <mpm@...enic.com> wrote:

> Here's a more expansive version:
> 
> ___Avoid checking lock-protected entropy_count when lock isn't held. This
> fixes a bug reported by and diagnosed by Aaron Straus.
> 
> This fixes a regression introduced into 2.6.26 by
>  
>      commit adc782dae6c4c0f6fb679a48a544cfbcd79ae3dc
>      Author: Matt Mackall <mpm@...enic.com>
>      Date:   Tue Apr 29 01:03:07 2008 -0700
>  
>          random: simplify and rename credit_entropy_store

That regression already got fixed, and the fix is now in mainline and
is queued for 2.6.26.x.  So we would need a new rationale, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/