linux-kernel - Re: [patch 6/8] m68k: Define rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.DEB.1.00.0809041150040.12258@zirkon.biophys.uni-duesseldorf.de>
Date:	Thu, 04 Sep 2008 11:51:11 +0200 (CEST)
From:	Michael Schmitz <schmitz@...phys.uni-duesseldorf.de>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 6/8] m68k: Define rtc_lock on Atari

Hi Geert,

Acked as well ...

> The nvram and rtc-cmos drivers use the spinlock rtc_lock to protect against
> concurrent accesses to the CMOS memory. As m68k doesn't support SMP or preempt
> yet, the spinlock calls tend to get optimized away, but not for all
> configurations, causing in some rare cases:
>
> | ERROR: "rtc_lock" [drivers/rtc/rtc-cmos.ko] undefined!
> | ERROR: "rtc_lock" [drivers/char/nvram.ko] undefined!
>
> Add the spinlock to the Atari core code to avoid this.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Michael Schmitz <schmitz@...ian.org>

> ---
> arch/m68k/atari/time.c |    3 +++
> 1 file changed, 3 insertions(+)
>
> --- a/arch/m68k/atari/time.c
> +++ b/arch/m68k/atari/time.c
> @@ -20,6 +20,9 @@
>
> #include <asm/atariints.h>
>
> +DEFINE_SPINLOCK(rtc_lock);
> +EXPORT_SYMBOL_GPL(rtc_lock);
> +
> void __init
> atari_sched_init(irq_handler_t timer_routine)
> {
>
> --
> Gr{oetje,eeting}s,
>
> 						Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/