linux-kernel - Re: [PATCH 4/9] ASoC: Blackfin: DMA Driver for AC97 sound chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080904123741.GA13735@rakim.wolfsonmicro.main>
Date:	Thu, 4 Sep 2008 13:37:41 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Cliff Cai <cliff.cai@...log.com>
Subject: Re: [PATCH 4/9] ASoC: Blackfin: DMA Driver for AC97 sound chip

On Thu, Sep 04, 2008 at 04:22:03PM +0800, Bryan Wu wrote:
> From: Cliff Cai <cliff.cai@...log.com>
> 
> Signed-off-by: Bryan Wu <cooloney@...nel.org>
> Signed-off-by: Cliff Cai <cliff.cai@...log.com>

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

A couple of coding standards nits below but please fix these as an
incremental patch to save on reviewing.

> +	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> +		curr = sport_curr_offset_tx(sport) / sizeof(struct ac97_frame);
> +	else {
> +		curr = sport_curr_offset_rx(sport) / sizeof(struct ac97_frame);
> +
> +	}

Don't need the { }.

> +	ret = snd_pcm_hw_constraint_integer(runtime, \
> +			SNDRV_PCM_HW_PARAM_PERIODS);
> +	if (ret < 0)
> +		goto out;

No need for the line continuation here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/