linux-kernel - Re: [PATCH 7/9] ASoC: Blackfin: I2S CPU DAI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080904144343.GB32531@rakim.wolfsonmicro.main>
Date:	Thu, 4 Sep 2008 15:43:43 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Cliff Cai <cliff.cai@...log.com>
Subject: Re: [PATCH 7/9] ASoC: Blackfin: I2S CPU DAI driver

On Thu, Sep 04, 2008 at 04:22:06PM +0800, Bryan Wu wrote:
> From: Cliff Cai <cliff.cai@...log.com>
> 
> Signed-off-by: Cliff Cai <cliff.cai@...log.com>
> Signed-off-by: Bryan Wu <cooloney@...nel.org>

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

Please fix the minor issues below as incremental patches for ease of
review.

> +	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> +	case SND_SOC_DAIFMT_I2S:
> +		break;
> +	case SND_SOC_DAIFMT_LEFT_J:
> +		ret = -EINVAL;
> +		break;
> +	}

The SND_SOC_DAFIMT_LEFT_J: ought to be default: instead - there's more
DAI formats than just that.

> +	if (!bf5xx_i2s.master) {
> +	/*
> +	 * TX and RX are not independent,they are enabled at the same time,
> +	 * even if only one side is running.So,we need to configure both of
> +	 * them in advance.
> +	 *
> +	 * CPU DAI format:I2S, slave mode.
> +	 */

The indentation here is odd.  Also, is the expecation that this
configuration be done only once ever - nothing seems to clear the flag?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/