linux-kernel - Re: [PATCH] Revert commit e8aa4667baf74dfd85fbaab86861465acb811085

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Sep 2008 18:14:38 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Andreas Herrmann <andreas.herrmann3@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert commit e8aa4667baf74dfd85fbaab86861465acb811085

On Thu, 4 Sep 2008, Ingo Molnar wrote:

> 
> * Andreas Herrmann <andreas.herrmann3@....com> wrote:
> 
> > This reverts commit e8aa4667baf74dfd85fbaab86861465acb811085
> >  (x86: enable hpet=force for AMD SB400)
> > 
> > Since ATI/AMD decided not to support HPET on SB4xx it doesn't
> > make sense to enable this unsupported feature.
> > (I was not aware of this when submitting the quirk.)
> > 
> > If a system with SB4xx chipset provides an ACPI HPET table and does
> > not boot, "nohpet" should be used as kernel parameter.
> > 
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@....com>
> 
> applied to tip/x86/urgent, thanks Andreas. I guess a system broke due to 
> this commit?

Hmm, why do we remove something which needs to be force enabled by the
user anyway ?  

Is the HPET on these systems not working at all so the force enable
code is useless ?

Thanks,
	
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/