linux-kernel - Re: [PATH] Fix compilation when CONFIG_TRACE_IRQFLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48C0175B.3070500@ct.jp.nec.com>
Date:	Thu, 04 Sep 2008 10:14:03 -0700
From:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Rui Sousa <rui.p.m.sousa@...il.com>, linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATH] Fix compilation when CONFIG_TRACE_IRQFLAGS_SUPPORT is
 not set

Ingo Molnar wrote:
> * Rui Sousa <rui.p.m.sousa@...il.com> wrote:
> 
>> Hi,
>>
>> This patch fixes compilation if CONFIG_TRACE_IRQFLAGS_SUPPORT is ever 
>> disabled (which is currently not allowed by Kconfig). Alternatively we 
>> could just remove the option altogether and the associated code paths. 
>> Since the compilation error has been in the tree for at least two 
>> years and no one noticed it, I guess we don't really have the need for 
>> CONFIG_TRACE_IRQFLAGS_SUPPORT=n. Boot tested on x86 UP.
> 
> applied to tip/core/locking - thanks Rui.
> 
> since you fixed it i prefer the fix over the removal. We could still 
> remove the !TRACE_IRQFLAGS_SUPPORT now (in a separate commit) and 
> simpify this header a bit that way. Thus if someone needs the 
> !TRACE_IRQFLAGS_SUPPORT mode of build for future work, it can be 
> restored via a simple revert.

Hi, it seems that this patch breaks uml build.

kernel/printk.c: In function 'vprintk':
kernel/printk.c:674: error: implicit declaration of function 'raw_local_irq_save'
kernel/printk.c:772: error: implicit declaration of function 'raw_local_irq_restore'

thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/