Message-ID: <BAY110-W23D3CD96F1CD07678A9100C9590@phx.gbl>
Date:	Thu, 4 Sep 2008 03:54:10 +0000
From:	Cliff Cai <xcahua@...mail.com>
To:	Mark Brown <broonie@...ena.org.uk>
CC:	<linux-kernel@...r.kernel.org>, Bryan Wu <cooloney@...nel.org>,
	<alsa-devel@...a-project.org>, <lrg@...nel.org>
Subject: RE: [alsa-devel] [PATCH 1/4] ASOC: Blackfin driver for ALSA SoC
	framework





> Date: Wed, 3 Sep 2008 11:38:52 +0100
> From: broonie@...ena.org.uk
> To: Cliff.Cai@...log.com
> CC: linux-kernel@...r.kernel.org; cooloney@...nel.org; alsa-devel@...a-project.org; lrg@...nel.org
> Subject: Re: [alsa-devel] [PATCH 1/4] ASOC: Blackfin driver for ALSA SoC framework
>
> On Wed, Sep 03, 2008 at 12:09:49PM +0800, Cai, Cliff wrote:
>
> Cliff, please fix your mail client configuration - the formatting of
> your reply makes little (if any) distinction between the text of my
> original mail which makes your message difficult to read.
>
>> -----Original Message-----
>> From: Mark Brown [mailto:broonie@...ena.org.uk]
>> Sent: Wednesday, August 27, 2008 9:49 PM
>> To: Bryan Wu
>> Cc: perex@...ex.cz; lrg@...nel.org; alsa-devel@...a-project.org;
>> linux-kernel@...r.kernel.org; Cliff Cai
>> Subject: Re: [PATCH 1/4] ASOC: Blackfin driver for ALSA SoC framework
>
>> On Wed, Aug 27, 2008 at 05:39:25PM +0800, Bryan Wu wrote:
>>> From: Cliff Cai 
>
>>>Again, odd blank lines and presumably there needs to be something to
>> undo things on error?
>
>> t's not necessary to do anything else on error, these functions only set
>> registers.
>
> And none of these settings will leave things so that the port looks busy
> or anything like that?


No,they are called just to configure somthing but won't start it,it only fails when the port is busy.


>
>> TX and RX Clocks are also not independent,currently,in order to
>> implement full duplex,we have to enable both RX and TX side even if
>> there is only a steam is opened,
>> And make the other side running on a dummy buffer,so all registers
>> cann't be configured any more. when the second stream is opened we just
>> switch the DMA form dummy buffer to the normal data buffer.
>
> Right, in that case your driver should use constraints to stop
> applications trying to configure the capture and playback sides
> differently.
>
>>>I'm also not seeing the code that configures the sample rate anywhere -
>> but then it looks like the driver only support slave mode ATM? That's
>> what the machine driver is
>>>using. There should still be a set_fmt() to document what's supported
>> if nothing else.
>
>> Yes ,the codec runs in master mode and provides bit clock..Do you mean
>> just implement a dummy set_fmt() with comments for CPU DAI,
>
> It shouldn't just be a dummy - it should reject DAI formats other than
> CBS_CFM if that is the only configuration that's supported.
>
>> Refer to my description above,it's not possible to configure anything
>> for CPU DAI after a stream is opened ,that why we have to configure CPU
>> DAI before any stream is opened.
>
> This is normal (and generally trying would result in audio artifacts if
> you try), but normally there is at least some configuration that can be
> done before the stream actually starts running.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_________________________________________________________________
一边聊天一边快速搜索，并把结果共享给好友，立刻试试！
http://im.live.cn/Share/18.htm
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists