linux-kernel - Re: [alsa-devel] [PATCH] add the nvidia HDMI codec driver for MCP77/79

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5habeoo0ia.wl%tiwai@suse.de>
Date:	Thu, 04 Sep 2008 09:04:13 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Pavel Hofman <pavel.hofman@...ite.cz>
Cc:	Wei Ni <wni@...dia.com>, Peer Chen <pchen@...dia.com>,
	alsa-devel <alsa-devel@...a-project.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [alsa-devel] [PATCH] add the nvidia HDMI codec driver for	MCP77/79

At Wed, 03 Sep 2008 14:11:16 +0200,
Pavel Hofman wrote:
> 
> 
> >> ......
> >> According to these codes, It only can get the realtek codec and can not
> >> get hdmi codec, if just change azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
> >> I think if remove "if (!audio_codecs)", it will be better, and I only
> >> need to chang azx_max_codecs[AZX_DRIVER_NVIDIA] to 4
> > 
> > Well, the check is there for a good reason.
> > 
> > There are many machines with broken BIOS reporting the 4th slot
> > available although it isn't actually.  It's a workaround to skip such
> > a bogus information.  So, it cannot be changed so easily.
> > 
> > We need to sort out this in a better way...  Oh well.
> 
> 
> Please, please, put the above information as a comment to the respective 
> place. These "hacks" should be commented :)

I changed that code yesterday with a little bit more comment.

Wei, Peer, could you regenerate the patch based on the latest sound
git tree?

    git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

or use the snapshot tarball from

    ftp://ftp.kernel.org/pub/linux/tiwai/snapshot/

This already contains the fix for the 4th slot probe on Nvidia
chipset.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/