linux-kernel - Re: [alsa-devel] [PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080905131049.GH12383@sirena.org.uk>
Date:	Fri, 5 Sep 2008 14:10:50 +0100
From:	Mark Brown <broonie@...ena.org.uk>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	Cliff Cai <cliff.cai@...log.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver

On Fri, Sep 05, 2008 at 06:21:35PM +0800, Bryan Wu wrote:

> +	/* Maybe the dummy buffer descriptor ring is damaged */
> +	sport->dummy_rx_desc->next_desc_addr = \
> +			(unsigned long)(sport->dummy_rx_desc+1);

Here and elsewhere in this driver you've got continuation characters
which aren't need.  I've fixed this up locally (and some additional
checkpatch/coding standards things) here and in other patches in the
series.

Otherwise the patch series looks good to go, thanks - I'm just about to
review the codec driver patch that it depends upon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/