linux-kernel - Re: [patch 1/2] x2apic: fix reserved APIC register accesses in print_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.55.0809052151430.7062@cliff.in.clinika.pl>
Date:	Fri, 5 Sep 2008 22:02:22 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Suresh Siddha <suresh.b.siddha@...el.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Yinghai Lu <yhlu.kernel@...il.com>
Subject: Re: [patch 1/2] x2apic: fix reserved APIC register accesses in
 print_local_APIC()

On Fri, 5 Sep 2008, Ingo Molnar wrote:

> hm, is the remote read debug output, now that it's not present in CPUs 
> made in the past 5 years or so, really that important?

 Maybe, maybe not, but if included it should be done correctly or
otherwise anotated why done differently.  Otherwise people may get
confused and propagate incorrect information as not everybody is inclined
to chase and cross-refer the relevant piece of documentation for each and
every bit of code fiddling with hardware.  In fact the requirement to do
so reduces trust in code it applies to and makes long-term maintenance a
nightmare.

 This observation applies universally of course.  I tend to look at code
without referring to documentation too as most often than not this is much
more effective time-wise.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/