linux-kernel - Re: [PATCH] ucb1400_ts depends SND_AC97

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Sep 2008 01:27:23 -0400 (EDT)
From:	Nicolas Pitre <nico@....org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Dmitry Torokhov <dtor@...ightbb.com>,
	lkml <linux-kernel@...r.kernel.org>, akpm <akpm@...l.org>,
	linux-next@...r.kernel.org
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS

On Thu, 4 Sep 2008, Randy Dunlap wrote:

> On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
> 
> > On Thu, 4 Sep 2008, Randy Dunlap wrote:
> > 
> > > On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
> > > 
> > > > On Sat, 9 Dec 2006, Randy Dunlap wrote:
> > > > 
> > > > > On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
> > > > > 
> > > > > > Please consider what SND_CONFIG_AC97_BUS corresponds to.  It is 
> > > > > > sound/pci/ac97/ac97_bus.c and if you look into this file you'll see that 
> > > > > > it is perfectly buildable even if sound is entirely configured out, just 
> > > > > > like some lib code would be.
> > > > > 
> > > > > OK.  Should it (CONFIG_SND_AC97_BUS -> sound/pci/ac97/ac97_bus.c)
> > > > > be buildable when sound is disabled?
> > > > 
> > > > Yes.
> > > > 
> > > > > If so, where should it be moved to (since afaik, make won't even
> > > > > descend into sound/ if SOUND=n; I don't see that changing
> > > > > any time soon).
> > > > 
> > > > What about this patch?
> > > 
> > > Can we get this patch or some patch into the input tree for linux-next?
> > 
> > This patch is commit e1036502e5263851259d147771226161e5ccc85a and 
> > appeared in mainline almost 2 years ago.
> 
> Ack.  Sorry about that.  Wrong ucb thread.
> 
> ucb1400_core still has build errors in linux-next
> since it uses ac97_bus_type even when CONFIG_SOUND=n.

What about this?

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 6e1e8c6..22cf319 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC
 
 config TOUCHSCREEN_UCB1400
 	tristate "Philips UCB1400 touchscreen"
-	select AC97_BUS
 	depends on UCB1400_CORE
 	help
 	  This enables support for the Philips UCB1400 touchscreen interface.
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 5dba165..70355d3 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -52,6 +52,7 @@ config HTC_PASIC3
 
 config UCB1400_CORE
 	tristate "Philips UCB1400 Core driver"
+	select AC97_BUS
 	help
 	  This enables support for the Philips UCB1400 core functions.
 	  The UCB1400 is an AC97 audio codec.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/