linux-kernel - Re: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.55.0809062104570.13851@cliff.in.clinika.pl>
Date:	Sat, 6 Sep 2008 21:08:51 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Cyrill Gorcunov <gorcunov@...il.com>
cc:	Yinghai Lu <yhlu.kernel@...il.com>, Ingo Molnar <mingo@...e.hu>,
	hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs

On Sat, 6 Sep 2008, Cyrill Gorcunov wrote:

> So I think better would be just use Ingo's suggestion
> about to separate apic/pin iterator and function body.

 No doubt about it.  Then if the number of entries was to be huge, then
lines output to the log buffer could be limited to 80 characters.  With
the use of sprintf() it would be rather trivial.  And you would avoid any
concerns about stack consumption.

 Please note that with MPS 1.1 systems the number of "unconnected" I/O 
APIC inputs can be considerable.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/