[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LFD.1.10.0809061351170.3117@nehalem.linux-foundation.org>
Date: Sat, 6 Sep 2008 13:55:07 -0700 (PDT)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Thomas Gleixner <tglx@...utronix.de>
cc: Alok Kataria <akataria@...are.com>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
LKML <linux-kernel@...r.kernel.org>,
Arjan van de Veen <arjan@...radead.org>,
"H. Peter Anvin" <hpa@...or.com>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Dan Hecht <dhecht@...are.com>,
Garrett Smith <garrett@...are.com>
Subject: Re: [RFC patch 0/4] TSC calibration improvements
On Sat, 6 Sep 2008, Linus Torvalds wrote:
>
>
> On Sat, 6 Sep 2008, Thomas Gleixner wrote:
> >
> > Just checked. The -tip version still has the expect-- in the for()
> > which might lead to stupid results depending on the gcc madness level.
>
> Umm. What? You're on some odd drugs.
Oh, you mean te "--expect" in the last pit_expect_msb(). Yeah, that one
looks bogus, but I don't understand what it has to do with gcc at all.
"expect" is an unsigned char. There are absolutely _zero_ issues with
overflow, underflow, random phases of the moon, madness levels or anything
else. But yes, it does look like Ingo screwed up when adding that final
check, since expect was already decremented at the end of the loop.
Ingo? Did you actually test it?
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists