linux-kernel - Re: [RFC:Patch: 008/008](memory hotplug) remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1220710895.8687.12.camel@twins.programming.kicks-ass.net>
Date:	Sat, 06 Sep 2008 16:21:35 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Yasunori Goto <y-goto@...fujitsu.com>
Cc:	Badari Pulavarty <pbadari@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mel@....ul.ie>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	Linux Kernel ML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC:Patch: 008/008](memory hotplug) remove_pgdat() function

On Thu, 2008-07-31 at 21:04 +0900, Yasunori Goto wrote:

> +int remove_pgdat(int nid)
> +{
> +	struct pglist_data *pgdat = NODE_DATA(nid);
> +
> +	if (cpus_busy_on_node(nid))
> +		return -EBUSY;
> +
> +	if (sections_busy_on_node(pgdat))
> +		return -EBUSY;
> +
> +	node_set_offline(nid);
> +	synchronize_sched();
> +	synchronize_srcu(&pgdat_remove_srcu);
> +
> +	free_pgdat(nid, pgdat);
> +
> +	return 0;
> +}

FWIW synchronize_sched() is the wrong function to use here,
synchronize_rcu() is the right one.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/