linux-kernel - Re: [PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080906160137.GC5061@elte.hu>
Date:	Sat, 6 Sep 2008 18:01:37 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	"David S. Miller" <davem@...emloft.net>,
	Ivo van Doorn <IvDoorn@...il.com>,
	"John W. Linville" <linville@...driver.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Theodore Tso <tytso@....edu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jan Beulich <jbeulich@...ell.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions


* Boaz Harrosh <bharrosh@...asas.com> wrote:

> Submitted a patchset to fix BUILD_BUG_ON to no longer let through
> none compile-time constant expressions. This was debated a few
> times on LKML. The final solution is as proposed by Rusty Russell,
> which produces all expected results in my tests.
> [see: http://www.spinics.net/lists/kernel/msg772904.html]
> 
> [PATCH 1/5] debug, x86: move BUILD_BUG_ON() ARRAY_SIZE and __FUNCTION__
>   Ingo this is your patch. Please verify?

yeah.

Acked-by: Ingo Molnar <mingo@...e.hu>

> [PATCH 5/5] debug: BUILD_BUG_ON: error on none-const expressions
>   Finally after all call sites are fixed this can go in.
>   (Rusty this one is From: you)

v3 looks good to me.

Andrew, are you picking this up? Looks like the perfect fit for -mm to 
me. I can drop the previous version from -tip so that there's no 
linux-next conflict.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/