linux-kernel - Re: [RFC 11/13] genapic: reduce stack pressuge in io_apic.c step 3 target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 7 Sep 2008 09:55:17 +0200
From:	"Bert Wesarg" <bert.wesarg@...glemail.com>
To:	"Mike Travis" <travis@....com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	davej@...emonkey.org.uk, "David Miller" <davem@...emloft.net>,
	"Eric Dumazet" <dada1@...mosbay.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Jack Steiner" <steiner@....com>,
	"Jeremy Fitzhardinge" <jeremy@...p.org>,
	"Jes Sorensen" <jes@....com>, "H. Peter Anvin" <hpa@...or.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 11/13] genapic: reduce stack pressuge in io_apic.c step 3 target_cpus

On Sun, Sep 7, 2008 at 01:50, Mike Travis <travis@....com> wrote:
>  * Step 3 "target_cpus" of cleaning up io_apic.c modifies the TARGET_CPUS
>    interface to pass a pointer to the returned mask for arch X86_64,
>    removing yet another "cpumask_t variable on the stack".
>
>        target_cpus = TARGET_CPUS;
>
>    becomes:
>
>        TARGET_CPUS(target_cpus);
>
>    For x86_32 this is expanded to:
>
>        target_cpus = (genapic->target_cpus());
>
>    For x86_64 this is expanded to:
>
>        target_cpus = (genapic->target_cpus)(&(target_cpus));
But its expended to:
         (genapic->target_cpus)(&(target_cpus));

> -#define TARGET_CPUS      (genapic->target_cpus())
> +#define TARGET_CPUS(retval) (genapic->target_cpus)(&(retval))


> +#ifdef CONFIG_X86_64
> +#define TARGET_CPUS(retval)      (genapic->target_cpus)(&(retval))
> +#else
> +#define TARGET_CPUS(retval)      retval = (genapic->target_cpus())
> +#endif

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/