lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 7 Sep 2008 11:11:12 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	linux-kernel@...r.kernel.org, Hugh Dickens <hugh@...itas.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Alan Jenkins <alan-jenkins@...fmail.co.uk>,
	Rafał Miłecki <zajec5@...il.com>
Subject: Re: [PATCH 3 of 3] x86: clean up memory corruption check and add
	more kernel parameters


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> +	memory_corruption_check=0/1 [X86]

could you please add a second .config parameter as well:

  CONFIG_BOOTPARAM_MEMORY_CORRUPTION_CHECK=y

which turns this parameter 1 without having to specify it on the boot 
command line. That way -tip's randconfig testing can check this on a 
couple of boxes and the WARN() will be detected automatically.

Also, i'd suggest to make the defaults of the scanning parameters be as 
widely enabled as reasonable - we want to see how much real problems 
this can catch.

> +config X86_CHECK_BIOS_CORRUPTION
> +        bool "Check for low memory corruption"
> +	default y

please make it default-disabled.

Looks good otherwise.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists