linux-kernel - Re: [RFC][PATCH] MMC: Use write timeout value as read from CSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080907123832.5ba79c12@mjolnir.drzeus.cx>
Date:	Sun, 7 Sep 2008 12:38:32 +0200
From:	Pierre Ossman <drzeus-mmc@...eus.cx>
To:	"Matt Fleming" <mattjfleming@...glemail.com>
Cc:	linux-kernel@...r.kernel.org, dbrownell@...rs.sourceforge.net
Subject: Re: [RFC][PATCH] MMC: Use write timeout value as read from CSR

On Mon, 1 Sep 2008 16:12:03 +0100
"Matt Fleming" <mattjfleming@...glemail.com> wrote:

> Currently, the MMC/SD over SPI code has a hard-coded timeout value of
> 250ms on writes. This is correct for SD cards and is specified in the
> spec, but it is not correct for MMC cards. For MMC cards the values
> that is read from the CSR should be used.
> 
> There is already code to ensure that the write timeout value for SD
> cards does not exceed 250ms, this patch only affects the MMC case.
> 

This actually isn't fully correct for SD either as it only specifies
that 250 ms is the upper bound on the timeout.

I believe the proper way of solving this is to have mmc_spi respect the
timeouts set in the request structure. Modify mmc_set_data_timeout() if
necessary.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/