[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080907154721.GA13177@elte.hu>
Date: Sun, 7 Sep 2008 17:47:21 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Cyrill Gorcunov <gorcunov@...il.com>
Cc: "Maciej W. Rozycki" <macro@...ux-mips.org>, hpa@...or.com,
linux-kernel@...r.kernel.org, tglx@...utronix.de,
yhlu.kernel@...il.com
Subject: Re: [patch 3/3] x86: io-apic - code style cleaning for
setup_IO_APIC_irqs
* Cyrill Gorcunov <gorcunov@...il.com> wrote:
> here is an another attempt to satisfy the requirements :)
> Please review and comment if it looks better or worse now.
sigh, i think the extra buffering is clearly worse. These are early init
printks and we already do many other cases of multi-line printouts and
even KERN_CONT printouts. We have a perfectly fine built-in buffer
already: the printk buffer.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists