linux-kernel - Re: [RFC PATCH v2 0/7] Tunable sched_mc_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1220882169.12278.23.camel@twins.programming.kicks-ass.net>
Date:	Mon, 08 Sep 2008 15:56:09 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	svaidy@...ux.vnet.ibm.com
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Suresh B Siddha <suresh.b.siddha@...el.com>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	Ingo Molnar <mingo@...e.hu>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Vatsa <vatsa@...ux.vnet.ibm.com>,
	Gautham R Shenoy <ego@...ibm.com>,
	Andi Kleen <andi@...stfloor.org>,
	David Collier-Brown <davecb@....com>,
	Tim Connors <tconnors@...ro.swin.edu.au>,
	Max Krasnyansky <maxk@...lcomm.com>
Subject: Re: [RFC PATCH v2 0/7] Tunable sched_mc_power_savings=n

On Mon, 2008-09-08 at 19:18 +0530, Vaidyanathan Srinivasan wrote:
> * Peter Zijlstra <a.p.zijlstra@...llo.nl> [2008-09-08 15:25:46]:
> 
> > May I again ask to first clean up the current power saving code before
> > stacking more on top of it?
> 
> :) I understand that you have asked for two things with respect to the
> current power save balance code:
> 
> 1. Detailed documentation

Preferably in the form of in-code comments and code structure, this
Documentation/* stuff always gets lost on me.

> 2. Cleanup the group_min and group_leader stuff in
>    find_busiest_group()
> 
> Did I get the requirements correct?

That would be much appreciated. 

But I also prefer to get rid of that power savings tweak in
cpu_coregroup_map(). 

But above all, readable code ;-)

find_busiest_group() is the stuff of nightmares.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/