linux-kernel - Re: [RFC] x86: io-apic - convert DO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080908143335.GD10580@elte.hu>
Date:	Mon, 8 Sep 2008 16:33:35 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC] x86: io-apic - convert DO_ACTION macro into function


* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> Convert DO_ACTION macro into more obvious io_apic_modify_irq
> function with callers
> ---
> 
>  I found it more readable then original was. Especialy we could grep 
> the callers in normal way. It's just an attempt - free to drop this 
> patch. I hope I don't messed with all these masks :) So the question 
> is rather NOT about details but idea in general.

yeah - getting rid of such macros is a very good idea in general.

>  io_apic.c |  102 ++++++++++++++++++++++++++++++--------------------------------
>  1 file changed, 50 insertions(+), 52 deletions(-)

that's non-trivial impact. Did the .o md5sum survive this transformation 
just fine? (in theory gcc should generate the same code - but it doesnt 
always do that across macro->inline function changes, so it's hard to 
validate these kinds of changes.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/