lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <48C5613E.76E4.0078.0@novell.com>
Date:	Mon, 08 Sep 2008 16:30:38 +0100
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>, <tglx@...utronix.de>,
	<linux-kernel@...r.kernel.org>, <hpa@...or.com>
Subject: Re: [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v2)

>>                c->x86_virt_bits = (eax >> 8) & 0xff;
>>                c->x86_phys_bits = eax & 0xff;
>> +               /* CPUID workaround for Intel 0F33/0F34 CPU */
>> +               if (c->x86_vendor == X86_VENDOR_INTEL
>> +                   && c->x86 == 0xF && c->x86_model == 0x3
>> +                   && (c->x86_mask == 0x3
>> +                       || c->x86_mask == 0x4))
>> +                       c->x86_phys_bits = 36;
>
>these lines should be in early_init_intel/init_intel.
>also need to be checked if it could be overwriten by others functions later..

I think this should then be a follow-up patch.

>BTW, did you address Peter's concern?

Sorry, I don't recall anything else I needed to address.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ