linux-kernel - Re: [PATCH] fix RTC_CLASS regression with PARISC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1220899189.8074.58.camel@localhost.localdomain>
Date:	Mon, 08 Sep 2008 13:39:49 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	David Brownell <david-b@...bell.net>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Parisc List <linux-parisc@...r.kernel.org>
Subject: Re: [PATCH] fix RTC_CLASS regression with PARISC

On Mon, 2008-09-08 at 11:19 -0700, David Brownell wrote:
> On Monday 08 September 2008, James Bottomley wrote:
> > Put it back again by making RTC_CLASS 
> > unselectable if the architecture is parisc.
> 
> Easier if those distros just wouldn't select RTC_CLASS then.  :)

Yes, but think of distro config people rather like users ... if you can
prevent them from doing something stupid, it's a good idea.  In this
case, there's currently no way anyone should ever select RTC_CLASS on
parisc, so we should make that clear in the Kconfig file.

> And long term, better to work with RTC_CLASS.  Eliminate that
> crufty asm-parisc/rtc.h file and one more GEN_RTC user; and
> share more widely-used infrastructure.
> 
> If I read things right, that would be easy:  the PARISC RTC is
> two firmware calls, ptc_tod_{read,set}(), which would map to
> RTC class {read,set}_time() methods of about six lines each.
> The RTC framework can do UIE emulation, if needed.

OK, I can look at that, but in the mean time could we make the option
that causes the damage unselectable?  This is technically a regression
because before your patch GEN_RTC would override RTC_CLASS, now it's the
other way around.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/